Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Java Java Objects Delivering the MVP Applying a Discount Code

Srinath V
Srinath V
1,624 Points

Having trouble with the second task of this challenge.

I have completed task 1 with no problems, but when I write my code to pass task 2, I get a message that says "Task 1 no longer passing". I don't know what part of my code made it so that task 1 would no longer work, and I would appreciate any help.

Thanks, Srinath

Order.java
public class Order {
  private String itemName;
  private int priceInCents;
  private String discountCode;

  public Order(String itemName, int priceInCents) {
    this.itemName = itemName;
    this.priceInCents = priceInCents;
  }

  public String getItemName() {
    return itemName;
  }

  public int getPriceInCents() {
    return priceInCents;
  }

  public String getDiscountCode() {
    return discountCode;
  }

  public void applyDiscountCode(String discountCode) {
    try {
    this.discountCode = normalizeDiscountCode(discountCode);
    } catch (IllegalArgumentException iae) {

    }
  }

  private String normalizeDiscountCode(String discountCode) {

    for (char letter : discountCode.toCharArray()) {
     if (Character.isLetter(letter) == false || discountCode.indexOf('$') == -1) {
      throw new IllegalArgumentException("Invalid discount code");
     }
    }

    return discountCode.toUpperCase();
  }

}
Example.java
public class Example {

  public static void main(String[] args) {
    // This is here just for example use cases.

    Order order = new Order(
            "Yoda PEZ Dispenser",
            600);

    // These are valid.  They are letters and the $ character only
    order.applyDiscountCode("abc");
    order.getDiscountCode(); // ABC

    order.applyDiscountCode("$ale");
    order.getDiscountCode(); // $ALE


    try {
      // This will throw an exception because it contains numbers
      order.applyDiscountCode("ABC123");
    } catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }
    try {
      // This will throw as well, because it contains a symbol.
      order.applyDiscountCode("w@w");
    }catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }

  }
}

1 Answer

Felix Sonnenholzer
Felix Sonnenholzer
14,654 Points

Hi there,

in your case the discountCode has to contain a '$'. For each char you check if it is a letter, and if it's not you look at the whole string and check if it contains a '$'.

Since it Task 1 only a normal string is tested without a $ it will always throw an Exception.

BTW you don't have to check the whole string, but just the char you are at.

  private String normalizeDiscountCode(String discountCode) {
    for (char c : discountCode.toCharArray()) { 
      if ( !(Character.isLetter(c) || c == '$')) { 
        throw new IllegalArgumentException("Invalid discount code");
      }
    }
    return discountCode.toUpperCase(); 
  }

Just for explanation if

  • c is a letter it returns true -> thanks to ! it will be false and won't throw an Exception
  • c is not a letter -> check if c is a $ -> check if c is a $
    • c is a $ it returns true -> thanks to ! it will be false and won't throw an Exception
    • c is not $ it returns false -> thanks to ! it will be true and will throw an Exception

I hope I expressed it easy to understand.

Have fun