Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Python Basics (2015) Letter Game App Letter Game Refinement

Sean Flanagan
Sean Flanagan
33,235 Points

Guess not defined

Hi.

When I run my program, after being asked to press Enter to play or Q to quit, I get this message:

_______                                                                                                       
Traceback (most recent call last):                                                                             
  File "letter_game.py", line 120, in <module>                                                                 
    play(done)                                                                                                 
  File "letter_game.py", line 78, in play                                                                      
    if guess in secret_word:                                                                                   
TypeError: 'in <string>' requires string as left operand, not tuple  

Here's my program:

import os
import random
import sys

# make a word list
words = [
    'apple', 
    'banana',
    'orange',
    'coconut',
    'strawberry',
    'lime',
    'grapefruit',
    'lemon',
    'kumquat',
    'blueberry',
    'tangarine',
    'peach',
    'pear',
    'blackberry',
    'raspberry',
    'cranberry',
    'melon',
    'satsuma',
    'raisin',
    'hazelnut',
    'sultana',
    'pineapple'
]

def clear():
    if os.name == 'nt':
        os.system('cls')
    else:
        os.system('clear')

def draw(bad_guesses, good_guesses, secret_word):
    clear()

    print('Strikes: {}/7'.format(len(bad_guesses)))
    print('')

    for letter in bad_guesses:
        print(letter, end=' ')
    print('\n\n')

    for letter in secret_word:
        if letter in good_guesses:
            print(letter, end='')
        else:
            print('_', end='')

    print('')

def get_guess(bad_guesses, good_guesses):
    while True:
        guess = input("Guess a letter: ").lower()

        if len(guess) != 1:
            print("You can only guess a single letter!")
        elif guess in bad_guesses or guess in good_guesses:
            print("You've already guessed that letter!")
        elif not guess.isalpha():
            print("You can only guess letters!")
        else:
            return guess

def play(done):
    clear()
    secret_word = random.choice(words)
    bad_guesses = []
    good_guesses = []

    while True:
        draw(bad_guesses, good_guesses, secret_word)
        guess = bad_guesses, good_guesses

        if guess in secret_word:
            good_guesses.append(guess)
            found = True
            for letter in secret_word:
                if letter not in good_guesses:
                    found = False

            if found:
                print("You win!")
                print("The secret word was {}".format(secret_word))
                done = True

        else:
            bad_guesses.append(guess)
            if len(bad_guesses) == 7:
                draw(bad_guesses, good_guesses, secret_word)
                print("You lose!")
                print("The secret word was {}".format(secret_word))
                done = True

        if done:
            play_again = input("Play again? Y/n ").lower()
            if play_again != 'n':
                return play(done=False)
            else:
                sys.exit()

def welcome():
    start = input("Press Enter/Return to start or Q to quit ").lower()
    if start == 'q':
        print("Bye")
        sys.exit()
    else:
        return True

print('Welcome to Letter Guess!')

done = False

while True:
    clear()
    welcome()
    play(done)

I'd appreciate any help.

Sean

2 Answers

Ryan S
Ryan S
27,276 Points

Hi Sean,

Alex is correct about the tuple. Although in the letter_game, "guess" is actually defined as the function "get_guess" which takes the arguments bad_guesses and good_guesses.

# should be:
guess = get_guess(bad_guesses, good_guesses)

#instead of:
guess = bad_guesses, good_guesses

Didn't remember that (watched Python Basics course like a year ago).

Nice catch!

Sean Flanagan
Sean Flanagan
33,235 Points

Hi Ryan.

You're quite right; I should have spotted that. I've given you Best Answer.

Thank you both for your help.

Sean :-)

The problem is you are checking if a tuple is in a string.

You have set "guess" to a tuple (don't worry; you'll learn all about tuple in a later course) of correct guesses and bad guesses. Try this instead of guess = bad_guesses, good_guesses.

# Over here I'm combining the lists together
guess = bad_guesses + good_guesses

Good luck! ~Alex