form_valid goes wrong

Question

I took what was necessary from the preceding video, but now it says Task 1 is no longer passing. Always a killer warning because it says nothing. I guess I have a typo?

accounts/views.py

from django.contrib.auth import login
from django.core.urlresolvers import reverse_lazy
from django.views import generic

from . import forms


class SignUp(generic.CreateView):
    form_class = forms.UserCreateForm
    template_name = 'accounts/signup.html'
    success_url = reverse_lazy('products:list')

    def form_valid(self, form):
        login(self.request, form.get_user())
        return super().form_valid(form)

Answer 1 · 2017-07-20T03:27:00Z

July 20, 2017 3:27am

You're started in the right direction. The method form_valid needs to return a valid form. But the form needs to validated to get at the form data. The solution is to call super() first, then save the result for the return statement.

The necessary steps are:

call super form to validate for, hold result to return later

    res = super().form_valid(form)

Get username and password1 from the form.cleaned_data dictionary
authenticate user with username and password1 and assign to user
login user using login(self.request, user)
return res from above

Post back if you need more help. Good Luck

Welcome to the Treehouse Community

Looking to learn something new?

Heidi Ulrich

Heidi Ulrich

form_valid goes wrong

1 Answer

Chris Freeman

Chris Freeman