Welcome to the Treehouse Community
Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.
Looking to learn something new?
Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.
Start your free trialCarl Axen
4,526 PointsFor the quotations I used a different approached. Please tell me if this is wrong or if not, what is the pros/cons
<aside>
<h3>What Attendees are Saying</h3>
<blockquote>"I've attended Front End DevConf 5 times. I look forward to another intensive day of learning and sharing!"
<cite><p>- Cody McCode</p></cite></blockquote>
<blockquote>"Front End DevConf is committed to being inclusive and welcoming for everyone!"
<cite><p>- Gram McProgrammer</p></cite></blockquote>
</aside>
1 Answer
Tim Knight
28,888 PointsHi Carl,
You're close here, but the video solution is probably a better way to go. Breaking that down a little bit... here's the video's solution from what I'm seeing:
<blockquote>
<p>"I've attended Front End DevConf 5 times. I look forward to another intensive day of learning and sharing!"</p>
<footer>- <cite>Cody McCode</cite></footer>
</blockquote>
And your solution...
<blockquote>"I've attended Front End DevConf 5 times. I look forward to another intensive day of learning and sharing!"
<cite><p>- Cody McCode</p></cite></blockquote>
I would say the key area for me would be the use of the paragraph tag. Adding a paragraph around the primary text of the quote is appropriate as a block of content. Putting that paragraph instead in the citation isn't really necessary however since it's already defined as a citation. What I do see as optional however would be the footer definition done in the video for the citation. I think defining that area as a footer could be argued. So combining both ideas you could probably settle on something below and be okay:
<blockquote>
<p>"I've attended Front End DevConf 5 times. I look forward to another intensive day of learning and sharing!"</p>
<cite>- Cody McCode</cite>
</blockquote>
Kristaps Vecvagars
6,193 PointsKristaps Vecvagars
6,193 PointsI'd say that the solution in the video is more of a "textbook solution" and yours is more of a custom one. Both solutions are correct in their own way, it's the task that matters. If your task was to recreate the perfect textbook HTML structure, then the video solution is probably the way to go. If you simply needed to mimic the visual layout, I'd say any approach, as long as it completes the task, would work.
Personally, I am not too fond of textbook solutions and from what I've seen, textbook markup seems to be a little bit too detailed for my tastes. However, if I was to attempt a test on markup specifically, I would try to keep in mind that my primary goal is to write detailed markup, not just mimic the visual layout.