Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Java Java Objects Creating the MVP Counting Scrabble Tiles

Michael Kingsley
Michael Kingsley
575 Points

for loop not stepping

I tested my variables, and the issue is that my if statement isn't catching. I've been starring at it for over two hours, and nothing I've tried has solved the issue.

Please advise.

public int getCountOfLetter(char tile) {

int count = 0;
for (char letter : tiles.toCharArray()) {
  if(tiles.indexOf(letter) == tile) {

   count ++;
   System.out.print("I'm working!" + count);
   System.out.print("count happened:   %i" + count);

  }   else {
    System.out.print ("Still not working"); 

  }
  System.out.println("I'm looping");
  System.out.print(count + "   ");
  System.out.print(letter + "   ");
  System.out.print(tile + "   ");

}

return count; }

ScrabblePlayer.java
public class ScrabblePlayer {
  // A String representing all of the tiles that this player has
  private String tiles;

  public ScrabblePlayer() {
    tiles = "";
  }

  public String getTiles() {
    return tiles;
  }

  public void addTile(char tile) {
    tiles += tile;
  }

  public boolean hasTile(char tile) {
    return tiles.indexOf(tile) != -1;
  }

  public int getCountOfLetter(char tile) {

    int count = 0;
    for (char letter : tiles.toCharArray()) {
      if(tiles.indexOf(letter) == tile) {

       count ++;
       System.out.print("I'm working!" + count);
       System.out.print("count happened:   %i" + count);

      }   else {
        System.out.print ("Still not working"); 

      }
      System.out.println("I'm looping");
      System.out.print(count + "   ");
      System.out.print(letter + "   ");
      System.out.print(tile + "   ");

    }
  return count;
  }
}
Example.java
// This code is here for example purposes only
public class Example {

  public static void main(String[] args) {
    ScrabblePlayer player1 = new ScrabblePlayer();
    player1.addTile('d');
    player1.addTile('d');
    player1.addTile('p');
    player1.addTile('e');
    player1.addTile('l');
    player1.addTile('u');

    ScrabblePlayer player2 = new ScrabblePlayer();
    player2.addTile('z');
    player2.addTile('z');
    player2.addTile('y');
    player2.addTile('f');
    player2.addTile('u');
    player2.addTile('z');

    int count = 0;
    // This would set count to 1 because player1 has 1 'p' tile in her collection of tiles
    count = player1.getCountOfLetter('p');
    // This would set count to 2 because player1 has 2 'd'' tiles in her collection of tiles
    count = player1.getCountOfLetter('d');
    // This would set 0, because there isn't an 'a' tile in player1's tiles
    count = player1.getCountOfLetter('a');

    // This will return 3 because player2 has 3 'z' tiles in his collection of tiles
    count = player2.getCountOfLetter('z');
    // This will return 1 because player2 has 1 'f' tiles in his collection of tiles
    count = player2.getCountOfLetter('f');
  }
}

There is something wrong here:

if(tiles.indexOf(letter) == tile)

because indexOf function returns an int or in other words a position in the String array and you are comparing it to char. So basically you are comparing int to char

1 Answer

Yanuar Prakoso
Yanuar Prakoso
15,196 Points

Hi Michael

I agree with Andris on this. You construct your IF statement wrong:

if(tiles.indexOf(letter) == tile)

as Andris said the left hand side returns int and the right hand side returns char.

While we are at it you should just use the for loop feature. You already loop for all letter in the String called tiles that has been converted to be a char array

That means you can directly compared each letter in that char array and see IF it matches the tile

This is how I will do:

int count = 0;
for (char letter : tiles.toCharArray()) {
  if(letter == tile) {

   count ++;
   }
}

I hope this can help a little