Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Python Basics (2015) Shopping List App Refactor

Posted by Addison DeViese
Addison DeViese
587 Points

Everything seems to be in order but it still says its wrong refactor python

Ive tried to find a problem with the spacing but have yet to find anything mind helping?

shopping_list.py 
def show_help():
    # print out instructions on how to use the app
    print("What should we pick up at the store?")
    print("""
Enter 'DONE' to stop adding items.
Enter 'HELP' for this help.
Enter 'SHOW' to see your current list.
""")

def show_list(shopping_list):
    # print out the list
    print("Here's your list:")

    for item in shopping_list:
        print(item)

def add_to_list(shopping_list, new_item):
    # add new items to our list
    shopping_list.append(new_item)
    print("Added {}. List now has {} items.".format(new_item, len(shopping_list)))
    return shopping_list
def main():  
    show_help()

# make a list to hold onto our items
    shopping_list = []

    while True:
    # ask for new items
        new_item = input("> ")

    # be able to quit the app
        if new_item == 'DONE':
            break
        elif new_item == 'HELP':
            show_help()
            continue
        elif new_item == 'SHOW':
            show_list(shopping_list)
            continue
    add_to_list(shopping_list, new_item)

show_list(shopping_list)

1 Answer

Alexander Davison
Alexander Davison
65,469 Points
Alexander Davison
Alexander Davison
65,469 Points

You need to indent properly.

Python thinks the add_to_list() function call is outside the while loop (it's supposed to be inside the while loop) and the show_list() function outside of the entire function!

To tell Python those are part of other sections, you must indent properly, as shown:

def main():
    show_help()

    # make a list to hold onto our items
    shopping_list = []

    while True:
        # ask for new items
        new_item = input("> ")

        # be able to quit the app
        if new_item == 'DONE':
            break
        elif new_item == 'HELP':
            show_help()
            continue
        elif new_item == 'SHOW':
            show_list(shopping_list)
            continue
        add_to_list(shopping_list, new_item)

    show_list(shopping_list)

Now, if you run this, Python will understand the add_to_list() function call in supposed to be inside the while loop and the show_list() function call is outside the loop, but inside the function.

I hope you understand. :)

If you got any questions, I'd be happy to answer. Just ask below and I'll reply as soon as possible :smile:

Good luck! ~Alex