Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript Object-Oriented JavaScript Getters and Setters Creating Setter Methods

Posted by Blessed Marufu
Blessed Marufu
3,927 Points

creating setters

good morning family , im getting this response how , what should i do ( Bummer: Maximum call stack size exceeded)

creating_setters.js 
class Student {
    constructor(gpa, credits){
        this.gpa = gpa;
        this.credits = credits;
    }

    stringGPA() {
        return this.gpa.toString();
    }
        get level() {
        if (this.credits > 90 ) {
            return 'Senior';
        } else if (this.credits > 60) {
            return 'Junior';
        } else if (this.credits > 30) {
            return 'Sophomore';
        } else {
            return 'Freshman';
        }
    }
  set major(major){
    this.major = 'major';
            if (this.level !== 'Senior' && this.level !== 'Junior') {
            this._major = 'None'}
  };

}

var student = new Student(3.9, 60);

1 Answer

Jaskaran Pannu
Jaskaran Pannu
1,564 Points
Jaskaran Pannu
Jaskaran Pannu
1,564 Points

Hey,

Use "OR" instead of "AND" in "IF" condition, As it will return 1 value ( either Junior/Senior....).

Solution is: 

 set major(major){
   if(this.level == 'Senior' || this.level == 'Junior')
       { this._major = major; }
               else {
             this._major= 'None';
    }
  }