Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Java Java Objects Delivering the MVP Applying a Discount Code

Code works as required in IDE, however, teamTreehouse browser ide rejects.

When i run the code in my IDE, it works just fine. However here, I get that its not working as described during a test case.

Order.java
public class Order {
    private String itemName;
    private int priceInCents;
    private String discountCode;

    public Order(String itemName, int priceInCents) {
      this.itemName = itemName;
      this.priceInCents = priceInCents;
    }

    public String getItemName() {
      return itemName;
    }

    public int getPriceInCents() {
      return priceInCents;
    }

    public String getDiscountCode() {
      return discountCode;
    }

    private String normalizeDiscountCode(String dCode) {
      String upperDiscountCode = dCode.toUpperCase();
      char[] cDiscountCode = upperDiscountCode.toCharArray();
      boolean isValid = false;
      for (int i = 0; i < cDiscountCode.length; i++) {
        if((cDiscountCode[i] >=65 && cDiscountCode[i] <= 90) || cDiscountCode[i] == 36) {
          isValid = true;
        } else {
          throw new IllegalArgumentException("Invalid discount code.");
        }
      }
      return upperDiscountCode;
    }

    public void applyDiscountCode(String discountCode) {
      try {
          this.discountCode = normalizeDiscountCode(discountCode);
      } catch(IllegalArgumentException iae){
            System.out.println(iae);
      }
    }
  }
Example.java
public class Example {

  public static void main(String[] args) {
    // This is here just for example use cases.

    Order order = new Order(
            "Yoda PEZ Dispenser",
            600);

    // These are valid.  They are letters and the $ character only
    order.applyDiscountCode("abc");
    order.getDiscountCode(); // ABC

    order.applyDiscountCode("$ale");
    order.getDiscountCode(); // $ALE


    try {
      // This will throw an exception because it contains numbers
      order.applyDiscountCode("ABC123");
    } catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }
    try {
      // This will throw as well, because it contains a symbol.
      order.applyDiscountCode("w@w");
    }catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }

  }
}

2 Answers

Hi Mahesh,

Your normalizeDiscountCode() function is coded properly. The problem is with your applyDiscountCode() function. The test code in Example.java is expecting the InvalidArgumentException to be passed back into the try/catch blocks it uses to test applyDiscountCode(). Because you have already added exception handling into applyDiscountCode() on your own, the tests for the challenge are not receiving an InvalidArgumentException and this is causing them to fail.

Revert your applyDiscountCode() function back to this and you should be all set:

public void applyDiscountCode(String discountCode) {
    this.discountCode = normalizeDiscountCode(discountCode);
}

Aaah. That makes sense. No wonder. Thanks a lot sir. Now i understand.