Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Python Basics (2015) Letter Game App Letter Game Refinement

Timothy Van Cauwenberge
Timothy Van Cauwenberge
8,958 Points
Posted by Timothy Van Cauwenberge
Timothy Van Cauwenberge
8,958 Points

Code only outputs one '_' for guessing everytime

Every time the code is ran, after you hit enter only one _ is shown to guess the "word"

import random

import os

import sys

words = [ 'apple', 'banana', 'orange', 'blueberry', 'melon', 'kumquat', 'lemon', 'lime', 'strawberry', 'kiwi', 'papaya' ]

def clear(): if os.name == 'nt': os.system('cls')#windows else: os.sysrtem('clear')#mac/linux

def draw(bad_guesses,good_guesses,secret_word): clear()

print('')
print('Strikes {}/7'.format(len(bad_guesses)))
print('\n')

for letter in bad_guesses:
    print(letter, end=' ')
print('')

for letter in secret_word:
    if letter in good_guesses:
        print(letter, end='')
else:
        print('_', end='')            

print('')

def get_guess(bad_guesses,good_guesses): while True: guess = input("Guess a letter: ").lower()

    if len(guess) != 1:
            print("You can only guess a single letter: ")
            continue

    elif guess in bad_guesses or guess in good_guesses:
        print("You've already guessed that letter!")
        continue

    elif not guess.isalpha():
        print("You can only guess letters!! ")
        continue
    else:
        return guess

def play(done): clear() secret_word = random.choice(words) bad_guesses = [] good_guesses = []

while True:
    draw(bad_guesses, good_guesses, secret_word)
    guess = get_guess(bad_guesses,good_guesses)

    if guess in secret_word:
        good_guesses.append(guess)
        found = True #did we find the word
        for letter in secret_word:
            if letter not in good_guesses:
                found = false #go through every letter in word
                #if word not found = false
        if found:
            print("You win! The secret word was {}".format(secret_word))
            done = True
    else:
        bad_guesses.append(guess)
        if len(bad_guesses) == 7:
            draw(bad_guesses,good_guesses,secret_word)
            print("You lost! The secret word was {}".format(secret_word))
            done = True
    if done:
        play_again = input("Play again? y/n ").lower()
        if play_again != 'n':
            returnplay(done=False)
        else:
            sys.exit()

def welcome(): start = input("Press enter/return to start or Q to quit ").lower() if start == 'q': print("Bye!") sys.exit() else: return True

print('Welcome to Letter Guess!\n')

done = False

while True: clear() welcome() play(done)

1 Answer

Nate Sturgeon
Nate Sturgeon
2,255 Points
Nate Sturgeon
Nate Sturgeon
2,255 Points

The problem is because your indentation is slightly off. Your else: clause executes at the end of your for: loop, instead of after your if: clause, so it only prints a _ once, after your code has checked for all the letters in secret_word. Change the indentation level so that it executes for every letter in secret_word that is not found in good_guesses, and you will be golden :)