Welcome to the Treehouse Community
Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.
Looking to learn something new?
Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.
Start your free trialsamuel zaffran
24,815 PointsCheck letters in String, can't do it !
Hi, when i put this code they tell me that the first task is no longer passing. I tried several things i don't know what to do next, please help.
public class Order {
private String itemName;
private int priceInCents;
private String discountCode;
private String normalizeDiscountCode(String code){
code = code.toUpperCase();
if(!code.contains("[A-Z]+") || code.indexOf("$")>-1)
throw new IllegalArgumentException("Invalid discount code");
return code.toUpperCase();
}
public Order(String itemName, int priceInCents) {
this.itemName = itemName;
this.priceInCents = priceInCents;
}
public String getItemName() {
return itemName;
}
public int getPriceInCents() {
return priceInCents;
}
public String getDiscountCode() {
return discountCode;
}
public void applyDiscountCode(String discountCode) {
this.discountCode = normalizeDiscountCode(discountCode);
}
}
public class Example {
public static void main(String[] args) {
// This is here just for example use cases.
Order order = new Order(
"Yoda PEZ Dispenser",
600);
// These are valid. They are letters and the $ character only
order.applyDiscountCode("abc");
order.getDiscountCode(); // ABC
order.applyDiscountCode("$ale");
order.getDiscountCode(); // $ALE
try {
// This will throw an exception because it contains numbers
order.applyDiscountCode("ABC123");
} catch (IllegalArgumentException iae) {
System.out.println(iae.getMessage()); // Prints "Invalid discount code"
}
try {
// This will throw as well, because it contains a symbol.
order.applyDiscountCode("w@w");
}catch (IllegalArgumentException iae) {
System.out.println(iae.getMessage()); // Prints "Invalid discount code"
}
}
}
samuel zaffran
24,815 PointsHi, In the right corner you can see the challenge.
2 Answers
Alex Bratkovskij
5,329 PointsHeya Samuel,
instead of
if(!code.contains("[A-Z]+") || code.indexOf("$")>-1)
try
private String normalizeDiscountCode(String discountCode) {
for( char letter : discountCode.toCharArray()) {
if(! (Character.isLetter(letter) || letter == '$')) {
throw new IllegalArgumentException("Invalid discount code");
}
}
return discountCode.toUpperCase();
}
The way to read it: Method that returns string called normalizeDiscountCode that takes string discountCode as an argument, check each letter in discountCode and if letter is not a letter nor a symbol $, throw IAE, if it is, return discountCode with upper casing.
Hope that helped. Best of luck! -Alex
samuel zaffran
24,815 PointsThank you i got it, i tried that method to, i just see now that i missed parentheses !
Alex Bratkovskij
5,329 PointsHappends!
Glad I could help, good luck!
-Alex
benjamind
6,442 Pointsbenjamind
6,442 PointsHow is this supposed to work:?
order.getDiscountCode(); // ABC
Should it not be: ???
String somestring = order.getDiscountCode();