Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Python Basics (2015) Shopping List App Refactor

Laknath Gunathilake
Laknath Gunathilake
1,860 Points

Cant't seem to pass the challenge

am I unable to pass the challenge?

because I have done something wrong with my indentation or because I have something wrong with the main function

shopping_list.py
def show_help():
    # print out instructions on how to use the app
    print("What should we pick up at the store?")
    print("""
Enter 'DONE' to stop adding items.
Enter 'HELP' for this help.
Enter 'SHOW' to see your current list.
""")

def show_list(shopping_list):
    # print out the list
    print("Here's your list:")

    for item in shopping_list:
        print(item)

def add_to_list(shopping_list, new_item):
    # add new items to our list
    shopping_list.append(new_item)
    print("Added {}. List now has {} items.".format(new_item, len(shopping_list)))
    return shopping_list
main():    
show_help()

# make a list to hold onto our items
shopping_list = []

  while True:
    # ask for new items
    new_item = input("> ")

    # be able to quit the app
      if new_item == 'DONE':
          break
      elif new_item == 'HELP':
        show_help()
          continue
      elif new_item == 'SHOW':
        show_list(shopping_list)
          continue
      add_to_list(shopping_list, new_item)

show_list(shopping_list)
main()

1 Answer

Kourosh Raeen
Kourosh Raeen
23,733 Points

To define the function main() you need to use the def keyword. Also, all the code after def main(): needs to be indented. You also, don't need to call main(), so delete the last line.

Laknath Gunathilake
Laknath Gunathilake
1,860 Points

Thank you. Do I need to indent everything to match the indentation level in the code above, or just the usual 4 spaces

Kourosh Raeen
Kourosh Raeen
23,733 Points

The code above is indented 4 spaces so I would go with the same.

Laknath Gunathilake
Laknath Gunathilake
1,860 Points

"still cant seem to pass the challenge" def show_help(): # print out instructions on how to use the app print("What should we pick up at the store?") print(""" Enter 'DONE' to stop adding items. Enter 'HELP' for this help. Enter 'SHOW' to see your current list. """)

def show_list(shopping_list): # print out the list print("Here's your list:")

for item in shopping_list:
    print(item)

def add_to_list(shopping_list, new_item): # add new items to our list shopping_list.append(new_item) print("Added {}. List now has {} items.".format(new_item, len(shopping_list))) return shopping_list def main():
show_help()

make a list to hold onto our items

shopping_list = []

while True: # ask for new items new_item = input("> ")

# be able to quit the app
  if new_item == 'DONE':
    break
  elif new_item == 'HELP':
    show_help()
    continue
  elif new_item == 'SHOW':
    show_list(shopping_list)
    continue
  add_to_list(shopping_list, new_item)

show_list(shopping_list)
Kourosh Raeen
Kourosh Raeen
23,733 Points

Without proper formatting of the code it would be difficult for me to see what the problem is. Please add three backticks, ` is a backtick, followed by the word python on a line by itself above your code. Then after the last line of your code add another line consisting of three backticks.

Laknath Gunathilake
Laknath Gunathilake
1,860 Points
<p>def show_help():
    # print out instructions on how to use the app
    print("What should we pick up at the store?")
    print("""
Enter 'DONE' to stop adding items.
Enter 'HELP' for this help.
Enter 'SHOW' to see your current list.
""")

def show_list(shopping_list):
    # print out the list
    print("Here's your list:")

    for item in shopping_list:
        print(item)

def add_to_list(shopping_list, new_item):
    # add new items to our list
    shopping_list.append(new_item)
    print("Added {}. List now has {} items.".format(new_item, len(shopping_list)))
    return shopping_list
def main():
  show_help()

# make a list to hold onto our items
shopping_list = []

    while True:
    # ask for new items
    new_item = input("> ")

    # be able to quit the app
    if new_item == 'DONE':
          break
    elif new_item == 'HELP':
        show_help()
          continue
    elif new_item == 'SHOW':
        show_list(shopping_list)
          continue
    add_to_list(shopping_list, new_item)

show_list(shopping_list) </p>
Kourosh Raeen
Kourosh Raeen
23,733 Points

After def main(): you still have a few lines of code that aren't indented.