Welcome to the Treehouse Community
Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.
Looking to learn something new?
Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.
Start your free trialHAIDER AL RUSTEM
859 PointsCannot finish this task
after i do task 2 by writing the method normalizeDiscountCode (String code), it says that task 1 is no longer valid. How can I solve this problem? what is wrong? I dont have any compiler errors.
public class Order { private String itemName; private int priceInCents; private String discountCode;
private boolean isAcceptable;
private String normalizeDiscountCode(String code){ code = code.toUpperCase();
do { isAcceptable = false;
for ( char letter : code.toCharArray() ){
boolean isAlphabetical = letter >= 'A' ;
boolean isDollarSign = code.indexOf('$') != -1;
if (isAlphabetical && isDollarSign)
{isAcceptable = true;}
else { throw new IllegalArgumentException (" Invalid discount! \n ");}
}
}
while (isAcceptable == false);
return code;
}
// this method was altered to call on the normalizeDiscountCode(discountCode) in task 1
public void applyDiscountCode(String discountCode) { this.discountCode = normalizeDiscountCode(discountCode); } }
public class Order {
private String itemName;
private int priceInCents;
private String discountCode;
private boolean isAcceptable;
private String normalizeDiscountCode(String code){
code = code.toUpperCase();
do { isAcceptable = false;
for ( char letter : code.toCharArray() ){
boolean isAlphabetical = letter >= 'A' ;
boolean isDollarSign = code.indexOf('$') != -1;
if (isAlphabetical && isDollarSign)
{isAcceptable = true;}
else { throw new IllegalArgumentException (" Invalid discount! \n ");}
}
}
while (isAcceptable == false);
return code;
}
public Order(String itemName, int priceInCents) {
this.itemName = itemName;
this.priceInCents = priceInCents;
}
public String getItemName() {
return itemName;
}
public int getPriceInCents() {
return priceInCents;
}
public String getDiscountCode() {
return discountCode;
}
public void applyDiscountCode(String discountCode) {
this.discountCode = normalizeDiscountCode(discountCode);
}
}
public class Example {
public static void main(String[] args) {
// This is here just for example use cases.
Order order = new Order(
"Yoda PEZ Dispenser",
600);
// These are valid. They are letters and the $ character only
order.applyDiscountCode("abc");
order.getDiscountCode(); // ABC
order.applyDiscountCode("$ale");
order.getDiscountCode(); // $ALE
try {
// This will throw an exception because it contains numbers
order.applyDiscountCode("ABC123");
} catch (IllegalArgumentException iae) {
System.out.println(iae.getMessage()); // Prints "Invalid discount code"
}
try {
// This will throw as well, because it contains a symbol.
order.applyDiscountCode("w@w");
}catch (IllegalArgumentException iae) {
System.out.println(iae.getMessage()); // Prints "Invalid discount code"
}
}
}
1 Answer
Alex Bratkovskij
5,329 PointsOKay, so your enchanced for loop does half the job you're re-assigning it to him all over again, here lets simplify it:
private String normalizeDiscountCode(String code){
code = code.toUpperCase();
for ( char letter : code.toCharArray() ){
if(!(Character.isLetter(letter) || code.charAt(0) == '$')){
throw new IllegalArgumentException (" Invalid discount! \n ");
} else{
return code;
}
}
Hope this helped. -Alex