Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript and the DOM (Retiring) Getting a Handle on the DOM Selecting Multiple Elements

Posted by Masud Rana
Masud Rana
2,865 Points

Can someone please help me to find out what's wrong with this code?

Help please to find out where is the wrong with the code right here.

js/app.js 
var listItems;
var colors = ["#C2272D", "#F8931F", "#FFFF01", "#009245", "#0193D9", "#0C04ED", "#612F90"];
var listItems = document.querySelectorAll('#rainbow');
for(var i = 0; i < colors.length; i ++) {
  listItems[i].style.color = colors[i];    
}
index.html 
<!DOCTYPE html>
<html>
  <head>
    <title>Rainbow!</title>
  </head>
  <body>
    <ul id="rainbow">
      <li>This should be red</li>
      <li>This should be orange</li>
      <li>This should be yellow</li>
      <li>This should be green</li>
      <li>This should be blue</li>
      <li>This should be indigo</li>
      <li>This should be violet</li>
    </ul>
    <script src="js/app.js"></script>
  </body>
</html>

3 Answers

Steven Parker
Steven Parker
231,271 Points
Steven Parker
Steven Parker
231,271 Points

I see two issues:

  • variables should only be declared once (there should only be one "var listItems" line)
  • the selector should target the list items inside the "rainbow" list instead of the list itself
Masud Rana
Masud Rana
2,865 Points
Masud Rana
Masud Rana
2,865 Points

I couldn't understand your second point. any other details way for second point?

Steven Parker
Steven Parker
231,271 Points
Steven Parker
Steven Parker
231,271 Points

The selector '#rainbow' targets the list element (ul, just one of them), but you want to select the list item elements (li) within it ('#rainbow li').

Masud Rana
Masud Rana
2,865 Points
Masud Rana
Masud Rana
2,865 Points

Thanks.