Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Java Java Basics Perfecting the Prototype Looping until the value passes

Can someone help me with this challenge? (KNOCK KNOCK)

I don't really understand the order I have to put the code in and where everything goes.

KnockKnock.java
/*  So the age old knock knock joke goes like this:

    Person A:  Knock Knock.
    Person B:  Who's there?
    Person A:  Banana
    Person B:  Banana who?
    ...as long as Person A has answered Banana the above repeats endlessly
    ...assuming the person answers Orange we'd see
    Person B:  Orange who?
    ...and then the punchline.
    Person A:  Orange you glad I didn't say Banana again?
    (It's a really bad joke that makes it sound like "Aren't you glad I didn't say Banana again?")

    Let's just assume the only two words passed in from the console from Person B are either banana or orange.
*/

// ====BEGIN PROMPTING CODE====

// Person A asks:
String noun;
String who;
boolean isInvalidWord;
do {
console.printf("Knock Knock.\n");
isInvalidWord = (noun.equalsIgnoreCase("banana") ||
                        (noun.equalsIgnoreCase("orange"));
  noun = console.readLine("Who's there?  ");
                         if (isInvalidWord) {
                           (noun.equalsIgnoreCase("banana") ||
                           (noun.equalsIgnoreCase("orange"));
                           console.printf("%s who?\n", who);
                         }
                         } while (isInvalidWord);
// Person B asks and Person A's response is stored in the String who:


// Person B responds:


// ==== END PROMPTING CODE ====

4 Answers

Hi Nevin,

That's some serious code you're trying out there! The question assumes there are only two answers possible.

Have a look at a previous reply I wrote for a similar question and see if that helps:

https://teamtreehouse.com/forum/while-taking-this-challenge-should-i-still-insert-an-if-statement

Steve.

Although there is an simpler way to do this (view Steve Hunter's post), in keeping with your current logic, you should apply the following fixes:

  • Remove noun variable
  • Set isInvalidWord equal to "banana" (We're checking to see if Person B replied banana, not orange.)
  • Declare a value for who before checking it
  • . . .
String who;
boolean isInvalidWord;

do {
console.printf("Knock Knock.\n");

who = console.readLine("Who's there?  ");

  isInvalidWord = (who.equalsIgnoreCase("banana"));

  if (isInvalidWord) {
     console.printf("%s who?\n", who);
  } else {
   isInvalidWord = false;
   console.printf("Orange you glad I didn't say Banana again?");
  }

} while (isInvalidWord);

Thank you guys.

I hope you get it fixed.

I'd have to say that Tomasz's solution isn't quite what you're after (as it is currently posted). Be careful with that.

Steve.