Welcome to the Treehouse Community
Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.
Looking to learn something new?
Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.
Start your free trialVictor Georgescu
2,991 PointsCan anyone take a look at my code and tell me why it doesn't run as presented in the course?
Karaoke Machine:
package com.teamtreehouse;
import com.teamtreehouse.model.Song; import com.teamtreehouse.model.SongBook; import com.teamtreehouse.model.SongRequest;
import java.io.BufferedReader; import java.io.IOException; import java.io.InputStreamReader; import java.util.ArrayDeque; import java.util.ArrayList; import java.util.HashMap; import java.util.List; import java.util.Map; import java.util.Queue;
public class KaraokeMachine { private SongBook mSongBook; private BufferedReader mReader; private Queue<SongRequest> mSongRequestQueue;
private Map<String, String> mMenu;
public KaraokeMachine(SongBook songBook) {
mSongBook = songBook;
mReader = new BufferedReader(new InputStreamReader(System.in));
mSongRequestQueue = new ArrayDeque<SongRequest>();
mMenu = new HashMap<String, String>();
mMenu.put("add", "Add a new song to the song book");
mMenu.put("play", "Play next song in the queue");
mMenu.put("choose", "Choose a song to sing!");
mMenu.put("quit", "Give up. Exit the program");
}
private String promptAction() throws IOException {
System.out.printf("There are %d songs available and %d in the queue. Your options are: %n",
mSongBook.getSongCount(),
mSongRequestQueue.size());
for (Map.Entry<String, String> option : mMenu.entrySet()) {
System.out.printf("%s - %s %n",
option.getKey(),
option.getValue());
}
System.out.print("What do you want to do: ");
String choice = mReader.readLine();
return choice.trim().toLowerCase();
}
public void run() {
String choice = "";
do {
try {
choice = promptAction();
switch (choice) {
case "add":
Song song = promptNewSong();
mSongBook.addSong(song);
System.out.printf("%s added! %n%n", song);
break;
case "choose":
String singerName = promptForSingerName();
String artist = promptArtist();
Song artistSong = promptSongForArtist(artist);
SongRequest songRequest = new SongRequest(singerName, artistSong);
if (mSongRequestQueue.contains(songRequest)) {
System.out.printf("%n%n Whoops %s already requested %s!%n",
singerName,
artistSong);
break;
}
mSongRequestQueue.add(songRequest);
System.out.printf("You chose: %s %n", artistSong);
break;
case "play":
playNext();
break;
case "quit":
System.out.println("Thanks for playing!");
break;
default:
System.out.printf("Unknown choice: '%s'. Try again. %n%n%n",
choice);
}
} catch (IOException ioe) {
System.out.println("Problem with input");
ioe.printStackTrace();
}
} while (!choice.equals("quit"));
}
private String promptForSingerName() throws IOException {
System.out.println("Enter the singer's name: ");
return mReader.readLine();
}
private Song promptNewSong() throws IOException {
System.out.print("Enter the artist's name: ");
String artist = mReader.readLine();
System.out.print("Enter the title: ");
String title = mReader.readLine();
System.out.print("Enter the video URL: ");
String videoUrl = mReader.readLine();
return new Song(artist, title, videoUrl);
}
private String promptArtist() throws IOException {
System.out.println("Available artists:");
List<String> artists = new ArrayList<>(mSongBook.getArtists());
int index = promptForIndex(artists);
return artists.get(index);
}
private Song promptSongForArtist(String artist) throws IOException {
List<Song> songs = mSongBook.getSongsForArtist(artist);
List<String> songTitles = new ArrayList<>();
for (Song song : songs) {
songTitles.add(song.getTitle());
}
System.out.printf("Available songs for %s: %n", artist);
int index = promptForIndex(songTitles);
return songs.get(index);
}
private int promptForIndex(List<String> options) throws IOException {
int counter = 1;
for (String option : options) {
System.out.printf("%d.) %s %n", counter, option);
counter++;
}
System.out.print("Your choice: ");
String optionAsString = mReader.readLine();
int choice = Integer.parseInt(optionAsString.trim());
return choice - 1;
}
public void playNext() {
SongRequest songRequest = mSongRequestQueue.poll();
if (songRequest == null) {
System.out.println("Sorry there are no songs in the queue." +
" Use choose from the menu to add some");
} else {
Song song = songRequest.getSong();
System.out.printf("%n%n%n Ready %s? Open %s to hear %s by %s %n%n%n",
songRequest.getSingerName(),
song.getVideoUrl(),
song.getTitle(),
song.getArtist());
}
}
}
The result is:
There are 15 songs available and 0 in the queue. Your options are:
add - Add a new song to the song book
play - Play next song in the queue
choose - Choose a song to sing!
quit - Give up. Exit the program
What do you want to do: choose
Enter the singer's name:
Victor
Available artists:
1.) Jackson 5
2.) Journey
3.) Katy Perry
4.) Michael Jackson
5.) Ritchie Valens
6.) Taylor Swift
7.) The Cure
8.) U2
9.) Wilson Phillips
Your choice: 2
Available songs for Journey:
1.) Don't Stop Believin'
Your choice: 1
You chose: Song: Don't Stop Believin' by Journey
There are 15 songs available and 1 in the queue. Your options are:
add - Add a new song to the song book
play - Play next song in the queue
choose - Choose a song to sing!
quit - Give up. Exit the program
What do you want to do: choose
Enter the singer's name:
Paul
Available artists:
1.) Jackson 5
2.) Journey
3.) Katy Perry
4.) Michael Jackson
5.) Ritchie Valens
6.) Taylor Swift
7.) The Cure
8.) U2
9.) Wilson Phillips
Your choice: 2
Available songs for Journey:
1.) Don't Stop Believin'
Your choice: 1
You chose: Song: Don't Stop Believin' by Journey
There are 15 songs available and 2 in the queue. Your options are:
add - Add a new song to the song book
play - Play next song in the queue
choose - Choose a song to sing!
quit - Give up. Exit the program
What do you want to do:
As you can see it doesn't run the if statement in the choose case. What am I missing?
2 Answers
Alexander Nikiforov
Java Web Development Techdegree Graduate 22,175 PointsThe program runs fine. The problem is that in the video Craig enters the same singer, whose name is Craig
TWO times.
Whereas you enter first Victor
and then Paul
. Am I right ?
So here is your input:
There are 15 songs available and 0 in the queue. Your options are:
add - Add a new song to the song book
play - Play next song in the queue
choose - Choose a song to sing!
quit - Give up. Exit the program
What do you want to do:
choose
Enter the singer's name:
Victor
Available artists: 1.) Jackson 5 2.) Journey 3.) Katy Perry 4.) Michael Jackson 5.) Ritchie Valens 6.) Taylor Swift 7.) The Cure 8.) U2 9.) Wilson Phillips
Your choice: 2 Available songs for Journey: 1.) Don't Stop Believin'
Your choice: 1
You chose: Song: Don't Stop Believin' by Journey
There are 15 songs available and 1 in the queue. Your options are: add - Add a new song to the song book play - Play next song in the queue choose - Choose a song to sing! quit - Give up. Exit the program
What do you want to do: choose
Enter the singer's name:
Paul
Available artists: 1.) Jackson 5 2.) Journey 3.) Katy Perry 4.) Michael Jackson 5.) Ritchie Valens 6.) Taylor Swift 7.) The Cure 8.) U2 9.) Wilson Phillips
Your choice: 2
Available songs for Journey: 1.) Don't Stop Believin'
Your choice: 1
You chose: Song: Don't Stop Believin' by Journey
There are 15 songs available and 2 in the queue.
Your options are: add - Add a new song to the song book play - Play next song in the queue choose - Choose a song to sing! quit - Give up. Exit the program What do you want to do:
Please re-watch video at approximately 8:12
That is why if
clause in choose
does not work, because singerName
is different and SongRequest
is different.
Does it make sense ?
Victor Georgescu
2,991 PointsThanks for the explanation. It makes total sense. I guess I was too focused at the code itself and didn't payed attention to this minor detail.