Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Java Java Objects Delivering the MVP Applying a Discount Code

Pieterjan Espeel
Pieterjan Espeel
3,656 Points

By completing task 2, task 1 doesn't run anymore .. (Delivering The MVP (JAVA))

I have tried changing my code many times to figure out the cause of this but i can't seem to figure it out. For some reason task one doesn't work anymore after adding the code for task 1.

Order.java
public class Order {
  private String itemName;
  private int priceInCents;
  private String discountCode;

  public Order(String itemName, int priceInCents) {
    this.itemName = itemName;
    this.priceInCents = priceInCents;
  }

  public String getItemName() {
    return itemName;
  }

  public int getPriceInCents() {
    return priceInCents;
  }

  public String getDiscountCode() {
    return discountCode;
  }

  public void applyDiscountCode(String discountCode) {
    this.discountCode = normalizeDiscountCode(discountCode);
  }
  private String normalizeDiscountCode(String discountCode) {
    for (char letter : discountCode.toCharArray()) {
      if (!Character.isLetter(letter) || letter != '$') {
        throw new IllegalArgumentException("Invalid Discountcode");
      } 
    }  
    return discountCode.toUpperCase();
  }
}
Example.java
public class Example {

  public static void main(String[] args) {
    // This is here just for example use cases.

    Order order = new Order(
            "Yoda PEZ Dispenser",
            600);

    // These are valid.  They are letters and the $ character only
    order.applyDiscountCode("abc");
    order.getDiscountCode(); // ABC

    order.applyDiscountCode("$ale");
    order.getDiscountCode(); // $ALE


    try {
      // This will throw an exception because it contains numbers
      order.applyDiscountCode("ABC123");
    } catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }
    try {
      // This will throw as well, because it contains a symbol.
      order.applyDiscountCode("w@w");
    }catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }

  }
}

1 Answer

Jennifer Nordell
seal-mask
STAFF
.a{fill-rule:evenodd;}techdegree
Jennifer Nordell
Treehouse Teacher

Hi there! You're very close here. In fact, you're only off by two characters. The reason the code isn't passing is because it's throwing the exception every time. Let's look at the conditional statement:

if (!Character.isLetter(letter) || letter != '$')

This line says if the character is not a letter or the character is not a dollar sign, throw an exception. Remember, only one of those has to be true to evaluate to true and the exception will be thrown. If I pass in "T", that fails the first condition, but because it's not a dollar sign, the exception is thrown. This means that this condition will evaluate to true for every character that isn't a dollar sign. The dollar sign is the only character that won't cause the error to be thrown.

What you're looking for is this statement: if the character is not a letter and the character is not a dollar sign, throw the exception.

Changing your "or" to an "and" fixes the problem.

Hope this helps! :sparkles:

Pieterjan Espeel
Pieterjan Espeel
3,656 Points

Thankyou very much for the help !!