Bummer: Your setter method is returning the wrong value for the major property.

Question

Guide me in the right direction. What am I missing? Video is unhelpful.

creating_setters.js

class Student {
    constructor(gpa, credits){
        this.gpa = gpa;
        this.credits = credits;
    }

    stringGPA() {
        return this.gpa.toString();
    }

    get level() {
        if (this.credits > 90 ) {
            return 'Senior';
        } else if (this.credits > 60) {
            return 'Junior';
        } else if (this.credits > 30) {
            return 'Sophomore';
        } else {
            return 'Freshman';
        }
    }


  set major(major) {
    if (this.level === 'Senior' || 'Junior') {
      this._major = major;
    } else if (this.level === 'Sophomore' || 'Freshman') {
      this._major = 'None';
    }
  }
}

var student = new Student(3.9, 60);

Answer 1 · 2021-08-26T14:30:13Z

August 26, 2021 2:30pm

Hi Devin Ramirez

You are on the right track, with just one error (and it is a very common error early on in code learning).

When using a comparative like OR (||) in a conditional statement, you need to specify each check to what is being checked specifically and directly.
Unlike spoken English, you can't just say "I want the apple that is red OR blue." In code, you would need to say "I want the apple that is red OR the apple that is blue." Notice how "apple" is repeated.

So in this exercise, you are comparing each thing to this.level. So instead of

this.level === 'Senior' || 'Junior'

you would need to do

this.level === 'Senior' || this.level === 'Junior'

Nice work.

:)

Welcome to the Treehouse Community

Looking to learn something new?

Devin Ramirez

Devin Ramirez

Bummer: Your setter method is returning the wrong value for the major property.

1 Answer

Jason Anders

Jason Anders