Welcome to the Treehouse Community
Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.
Looking to learn something new?
Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.
Start your free trialpeterbristow
10,403 PointsBummer: java.lang.IllegalArgumentException: Invalid discount code (Look arround Oder.java line 26). Whaaat?
Hi
Any idea what I have done wrong here please?
Thanks.
private String normalizeDiscountCode(String discountCode) { for (char letter : discountCode.toCharArray()) { if (!Character.isLetter(letter) || letter != '$') { throw new IllegalArgumentException("Invalid discount code"); } } return discountCode.toUpperCase(); }
public void applyDiscountCode(String discountCode) { this.discountCode = normalizeDiscountCode(discountCode); // *** Line 26 is here. *** }
public class Order {
private String itemName;
private int priceInCents;
private String discountCode;
public Order(String itemName, int priceInCents) {
this.itemName = itemName;
this.priceInCents = priceInCents;
}
public String getItemName() {
return itemName;
}
public int getPriceInCents() {
return priceInCents;
}
public String getDiscountCode() {
return discountCode;
}
private String normalizeDiscountCode(String discountCode) {
for (char letter : discountCode.toCharArray()) {
if (!Character.isLetter(letter) || letter != '$') {
throw new IllegalArgumentException("Invalid discount code");
}
}
return discountCode.toUpperCase();
}
public void applyDiscountCode(String discountCode) {
this.discountCode = normalizeDiscountCode(discountCode);
}
}
public class Example {
public static void main(String[] args) {
// This is here just for example use cases.
Order order = new Order(
"Yoda PEZ Dispenser",
600);
// These are valid. They are letters and the $ character only
order.applyDiscountCode("abc");
order.getDiscountCode(); // ABC
order.applyDiscountCode("$ale");
order.getDiscountCode(); // $ALE
try {
// This will throw an exception because it contains numbers
order.applyDiscountCode("ABC123");
} catch (IllegalArgumentException iae) {
System.out.println(iae.getMessage()); // Prints "Invalid discount code"
}
try {
// This will throw as well, because it contains a symbol.
order.applyDiscountCode("w@w");
}catch (IllegalArgumentException iae) {
System.out.println(iae.getMessage()); // Prints "Invalid discount code"
}
}
}
Ani Azot
1,754 PointsAni Azot
1,754 Pointsyour 'or' needs to be an 'and'
If letter == '$'
Its value is tested against the condition !Character.isLetter(letter) <the '$' value of letter is NOT a letter>
This returns true as '$' is not a letter
Letter is not tested against the other side of the [or] condition once one side returns 'true' in the case of ||
Since the condition returned true, the statement between the brackets is called - throw new IllegalArgumentException("Invalid discount code");
So you need an && to make sure the other side of the if condition is called and both sides of the condition return true to call the throw new iae statement. This will make sure the value of letter is not a letter AND not a dollar symbol.
...I think! Sorry I'm quite new to Java