Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Java Java Basics Perfecting the Prototype Looping until the value passes

Posted by Fiqhi Damati
.a{fill-rule:evenodd;}techdegree
Fiqhi Damati
Java Web Development Techdegree Student 2,430 Points

Bummer is saying did you forget to put you glad but I put and tested it and it is working fine ?

String who; console.printf("Knock Knock.\n");

do { // Person B asks and Person A's response is stored in the String who: who = console.readLine("Who's there? "); // Person B responds: console.printf("%s who?\n", who); if (who.equalsIgnoreCase("banana") == false ) { 

  console.printf("%s  you glad I didn't say Banana again?", who);

} } while (who.equalsIgnoreCase("banana") );

KnockKnock.java 
      /*  So the age old knock knock joke goes like this:

    Person A:  Knock Knock.
    Person B:  Who's there?
    Person A:  Banana
    Person B:  Banana who?
    ...as long as Person A has answered Banana the above repeats endlessly
    ...assuming the person answers Orange we'd see
    Person B:  Orange who?
    ...and then the punchline.
    Person A:  Orange you glad I didn't say Banana again?
    (It's a really bad joke that makes it sound like "Aren't you glad I didn't say Banana again?")

    Let's just assume the only two words passed in from the console from Person B are either banana or orange.
*/

// ====BEGIN PROMPTING CODE====

// Person A asks:
String who;
console.printf("Knock Knock.\n");

do {
// Person B asks and Person A's response is stored in the String who:
who = console.readLine("Who's there?  "); 
// Person B responds:
console.printf("%s who?\n", who);
  if (who.equalsIgnoreCase("banana") == false ) {    

      console.printf("%s  you glad I didn't say Banana again?", who);
  }
} while (who.equalsIgnoreCase("banana") );
// ==== END PROMPTING CODE ====

1 Answer

Rob Bridges
seal-mask
.a{fill-rule:evenodd;}techdegree seal-36
Rob Bridges
Full Stack JavaScript Techdegree Graduate 35,467 Points
Rob Bridges
.a{fill-rule:evenodd;}techdegree seal-36
Rob Bridges
Full Stack JavaScript Techdegree Graduate 35,467 Points

Hello, the trouble with this code is that you do not need the nested if loop inside your while loop.

After you set up the while loop which you correctly did you will print the punchline outside of the loop.

The code should look a bit like this 

// ====BEGIN PROMPTING CODE====
String who;
do {
// Person A asks:
console.printf("Knock Knock.\n");

// Person B asks and Person A's response is stored in the String who:
 who = console.readLine("Who's there?  ");

// Person B responds:
console.printf("%s who?\n", who);
} while (who.equalsIgnoreCase("banana"));
console.printf("%s you glad I didn't say Banana again?", who);
// ==== END PROMPTING CODE ====```

Also, be sure that you only have one space after your %s, it looks like yours has one or two, this could also be the error that is being generated.