Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript Object-Oriented JavaScript Getters and Setters Creating Setter Methods

Posted by Hunter Initiative
Hunter Initiative
27,265 Points

backing property

Inside the major() setter method, set the student's major to a backing property "_major". If the student's level is Junior or Senior, the value of the backing property should be equal to the parameter passed to the setter method. If the student is only a Freshman or Sophomore, set the "_major" backing property equal to 'None'.

creating_setters.js 
class Student {
    constructor(gpa, credits){
        this.gpa = gpa;
        this.credits = credits;
    }

    stringGPA() {
        return this.gpa.toString();
    }

    get level() {
        if (this.credits > 90) {
            return 'Senior';
        } else if (this.credits > 60) {
            return 'Junior';
        } else if (this.credits > 30) {
            return 'Sophomore';
        } else {
            return 'Freshman';
        }
    }

    set major(major) {
      this._major = major;   
      if (this.credits > 90 || this.credits > 60 ) {
        return major;
      }else if(this.credits > 30 || this.credits < 30) {
        return 'none';
      }
    }

}

var student = new Student(3.9, 60);

2 Answers

Jonathan Grieve
MOD
Jonathan Grieve
Treehouse Moderator 91,253 Points
Jonathan Grieve
Jonathan Grieve
Treehouse Moderator 91,253 Points

You need to check your conditions against the level() get method.

e.g. if (this.level)

Make sure you then correctly set the value of the backing property, which has the underscore _ preceding it and rhe string matches what is in the question. So it's "None", not "none". That last bit might sound a bit picky but code challenges are like that, I'm afraid. :)

josephweiss2
josephweiss2
7,094 Points
josephweiss2
josephweiss2
7,094 Points

the problem is that your setting the major value even before the if statement, set the major property according the if statement, and you don't have to return anything, the if statement should SET the major according the conditions