Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Java Java Objects Delivering the MVP Applying a Discount Code

applying discount code, why is task 2 not working?

i cant understand why task 2 is working... when running code for task 2, a message appear saying task 1 is no longer working. and when i comment out the exception task 1 works again but 2 doesnt.

Order.java
public class Order {
  private String itemName;
  private int priceInCents;
  private String discountCode;
  private boolean isLettersOrDollar(String Code){
   for(char letter: discountCode.toCharArray()){
    if(!(Character.isLetter(letter)) && (letter!='$')){
     return false;
    }
   }
   return true;
  }
  private String normalizeDiscountCode(String Code){
    if(isLettersOrDollar(Code)){
      throw new IllegalArgumentException ("Invalid discount code");
    }
    return Code.toUpperCase();
  }
  public Order(String itemName, int priceInCents) {
    this.itemName = itemName;
    this.priceInCents = priceInCents;
  }

  public String getItemName() {
    return itemName;
  }

  public int getPriceInCents() {
    return priceInCents;
  }

  public String getDiscountCode() {
    return discountCode;
  }

  public void applyDiscountCode(String discountCode) {
    this.discountCode = normalizeDiscountCode(discountCode);
  }
}
Example.java
public class Example {

  public static void main(String[] args) {
    // This is here just for example use cases.

    Order order = new Order(
            "Yoda PEZ Dispenser",
            600);

    // These are valid.  They are letters and the $ character only
    order.applyDiscountCode("abc");
    order.getDiscountCode(); // ABC

    order.applyDiscountCode("$ale");
    order.getDiscountCode(); // $ALE


    try {
      // This will throw an exception because it contains numbers
      order.applyDiscountCode("ABC123");
    } catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }
    try {
      // This will throw as well, because it contains a symbol.
      order.applyDiscountCode("w@w");
    }catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }

  }
}

1 Answer

michaelcodes
michaelcodes
5,604 Points

Hi there! You were very close with this challenge. The main issue is that toCharArray was applied to the private member "discountCode" rather than the passed in method parameter "Code".

Shown below:

    private String normalizeDiscountCode(String Code){
    for(char letter: Code.toCharArray()){ //Here we need to turn Code into char array
    if( !(Character.isLetter(letter)) && letter != '$' ){
      throw new IllegalArgumentException ("Invalid discount code");
    }
    }
    return Code.toUpperCase();
  }

Hope this helps, if you have any more questions don't hesitate to ask! Take care and happy coding!