Welcome to the Treehouse Community
Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.
Looking to learn something new?
Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.
Start your free trialSachini Hansini Nawalaella
2,842 Pointsapplying a discount code
For this first task, create a new private method named normalizeDiscountCode. It should take the discount code that is passed into the method and return the uppercase version. Call it from the current applyDiscountCode method and set this.discountCode to the result.
Please help me with my code.i can not find my errors
public class Order {
private String itemName;
private int priceInCents;
private String discountCode;
public Order(String itemName, int priceInCents) {
this.itemName = itemName;
this.priceInCents = priceInCents;
}
public String getItemName() {
return itemName;
}
public int getPriceInCents() {
return priceInCents;
}
public String getDiscountCode() {
return discountCode;
}
public void applyDiscountCode(String discountCode) {
this.discountCode = discountCode;
}
}
private String normalizeDiscountCode(String discountCode)
{
String UpperCase = discountCode.toUpperCase();
for (char ch : discountCode.toCharArray())
{
if (! Character.isLetter(ch) && ch != '$')
{
throw new IllegalArgumentException("Invalid discount code.");
}
}
return UpperCase;
}
public class Example {
public static void main(String[] args) {
// This is here just for example use cases.
Order order = new Order(
"Yoda PEZ Dispenser",
600);
// These are valid. They are letters and the $ character only
order.applyDiscountCode("abc");
order.getDiscountCode(); // ABC
order.applyDiscountCode("$ale");
order.getDiscountCode(); // $ALE
try {
// This will throw an exception because it contains numbers
order.applyDiscountCode("ABC123");
} catch (IllegalArgumentException iae) {
System.out.println(iae.getMessage()); // Prints "Invalid discount code"
}
try {
// This will throw as well, because it contains a symbol.
order.applyDiscountCode("w@w");
}catch (IllegalArgumentException iae) {
System.out.println(iae.getMessage()); // Prints "Invalid discount code"
}
}
}
1 Answer
Richard Lambert
Courses Plus Student 7,180 PointsHello mate,
- Once
normalizeDiscountCode(String discountCode)
has been created, call it from withinapplyDiscountCode(String discountCode)
, passingdiscountCode
as the argument, and assigning the return value tothis.discountCode
. - The extra closing brace will cause a compile time error.
- I find that applying a consistent code style allows me to identify errors more effectively.
public void applyDiscountCode(String discountCode) {
this.discountCode = discountCode; // (1)
}
} // (2)
private String normalizeDiscountCode(String discountCode) { // (3)
String UpperCase = discountCode.toUpperCase();
for (char ch : discountCode.toCharArray()) {
if (! Character.isLetter(ch) && ch != '$') {
throw new IllegalArgumentException("Invalid discount code.");
}
}
return UpperCase;
}
Hope this helps
Sachini Hansini Nawalaella
2,842 PointsSachini Hansini Nawalaella
2,842 Pointsthank you for showing me my errors.